···
--
Michael Jackson | Owner, President
BlueQuartz Software
[e] mike.jackson@bluequartz.net
[w] www.bluequartz.net
From: Hdf-forum <hdf-forum-bounces@lists.hdfgroup.org> on behalf of Christian Oyarzun <christian.oyarzun@studsvik.com>
Reply-To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Date: Monday, January 8, 2018 at 8:23 AM
To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Subject: Re: [Hdf-forum] Issues with INSTALL using NMake Makefiles & CMake (1.8.19, 1.8.20)
This was previous reported in HDFFV-10296. Mike’s patch is more elegant as it uses the MSVC_IDE variable instead of CMAKE_GENERATOR and uses the escape character described in his email.
It would also be nice if HDFFV-10334 (fix to building static Fortran libraries on Windows with CMake 2.9 or greater) since both relate to Fortran CMAKE issues on Windows.
Thanks,
Christian Oyarzun
From: Hdf-forum <hdf-forum-bounces@lists.hdfgroup.org> on behalf of Michael Jackson <mike.jackson@bluequartz.net>
Reply-To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Date: Sunday, January 7, 2018 at 9:13 PM
To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Subject: Re: [Hdf-forum] Issues with INSTALL using NMake Makefiles & CMake (1.8.19, 1.8.20)
These changes seem to work, at least on my Windows 10x64, Visual Studio 2015 configuration. I tested with Visual Fortran 17. I have Visual Fortran 18 at my disposal also but I have not tried it yet.
In fortran/src/CMakeLists.txt file:
if (BUILD_SHARED_LIBS AND NOT SKIP_HDF5_FORTRAN_SHARED)
file (MAKE_DIRECTORY "${HDF5_F90_BINARY_DIR}/shared")
if (MSVC_IDE)
set (MODSH_BUILD_DIR "${CMAKE_Fortran_MODULE_DIRECTORY}/shared/\${CMAKE_INSTALL_CONFIG_NAME}")
else ()
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared)
endif ()
endif ()
if (MSVC_IDE)
set (MOD_BUILD_DIR "${CMAKE_Fortran_MODULE_DIRECTORY}/static/\${CMAKE_INSTALL_CONFIG_NAME}")
else ()
set (MOD_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/static)
endif ()
and in hl/fortran/src/CMakeLists.txt
if (BUILD_SHARED_LIBS AND NOT SKIP_HDF5_FORTRAN_SHARED)
file (MAKE_DIRECTORY "${HDF5_HL_F90_SRC_BINARY_DIR}/shared")
if (MSVC_IDE)
set (MODSH_BUILD_DIR "${CMAKE_Fortran_MODULE_DIRECTORY}/shared/\${CMAKE_INSTALL_CONFIG_NAME}")
else ()
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared)
endif ()
endif ()
if (MSVC_IDE)
set (MOD_BUILD_DIR "${CMAKE_Fortran_MODULE_DIRECTORY}/static/\${CMAKE_INSTALL_CONFIG_NAME}")
else ()
set (MOD_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/static)
endif ()
If you will notice the “\” in front of the $ which escapes that character effectively making ${CMAKE_INSTALL_CONFIG_NAME} just another string instead of an actual variable. We need this because the install rules are NOT evaluated at CMake time but at Build/Install time. With the escape in there that variable is passed into the actual cmake_install.cmake file that gets generated and run at Install time. In that file the escape character will no longer be present and it becomes an actual cmake variable that gets properly evaluated in that cmake file. This is needed for those generators like Visual Studio that do NOT have the notion of “CMAKE_BUILD_TYPE” like Ninja, JOM, NMake Makefiles do. If a developer is using one of those generators then the “else()” logic works just fine. I hope that was a reasonable explanation. I only tested on my configuration against the 1.8.20 git tag. I did look up the latest and the same code is in the 1.10.x codes.
--
Mike Jackson
BlueQuartz Software
[e]: mike.jackson@bluequartz.net
From: Hdf-forum <hdf-forum-bounces@lists.hdfgroup.org> on behalf of Elena Pourmal <epourmal@hdfgroup.org>
Reply-To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Date: Sunday, January 7, 2018 at 5:22 PM
To: HDF Users Discussion List <hdf-forum@lists.hdfgroup.org>
Subject: Re: [Hdf-forum] Issues with INSTALL using NMake Makefiles & CMake (1.8.19, 1.8.20)
Hi Mike and All,
Happy New Year!
HDF5 repository is https://bitbucket.hdfgroup.org/projects/HDFFV/repos/hdf5/browse\. You may also send the patch to help@hdfgroup.org.
We will discuss the problem tomorrow during our developers meeting.
Thank you!
Elena
On Jan 7, 2018, at 2:58 PM, Michael Jackson <mike.jackson@bluequartz.net> wrote:
I’m having an issue configuring HDF5 1.8.19 and 1.8.20. My configuration environment is:
+ Visual Studio 14 2015 Win64
+ Intel Visual Fortran 17
+ CMake 3.8.x
+ NMake Makefiles
When I try the install the install script will complain that it cannot find a few files. After some debugging through the CMake code I have determined that the issue is in places like the hl/fortran/src/CMakeLists.txt
if (WIN32)
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared/${CMAKE_BUILD_TYPE})
else ()
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared)
endif ()
That “WIN32” logic assumes a Visual Studio build. When using NMake (or most likely anything OTHER than Visual Studio) the trailing /${CMAKE_BUILD_TYPE} folder will NOT be present. The fix is to do:
if (MSVC_IDE)
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared/${CMAKE_BUILD_TYPE})
else ()
set (MODSH_BUILD_DIR ${CMAKE_Fortran_MODULE_DIRECTORY}/shared)
endif ()
Which will ONLY use that subfolder logic for Visual Studio builds. Where is the Git repository for HDF5? I can get a patch together and submit a pull request with the full fixes. I have not had the time to try out the 1.10.x sources so I do NOT know if this was found and fixed for those releases.
Thanks
--
Michael A. Jackson 400 S. Pioneer Blvd
Owner, President Springboro, Ohio 45066
BlueQuartz Software, LLC EMail: mike.jackson@bluequartz.net
Voice: 937-790-1601 Web: http://www.bluequartz.net
Fax: 937-746-0783
_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@lists.hdfgroup.org
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5
_______________________________________________ Hdf-forum is for HDF software users discussion. Hdf-forum@lists.hdfgroup.org http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org Twitter: https://twitter.com/hdf5
The information contained in this email message, including any attachments, contains or may contain proprietary and confidential information intended only for the addressee. It is furnished with the understanding that it is for the sole use of the addressee and may only be used for the purposes for which it has been delivered by Studsvik or its designee. The information contained herein shall not be copied, reproduced or transmitted to any other parties, nor shall it be used for any other purpose, without prior written consent of Studsvik. If you have received this email in error, please return it to the sender and destroy or otherwise permanently delete the copy received.
_______________________________________________ Hdf-forum is for HDF software users discussion. Hdf-forum@lists.hdfgroup.org http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org Twitter: https://twitter.com/hdf5
