Line 185 of h5pfc on version 1.8.17 has a typo. outputfile should be output_file
sed -e 's/outputfile/output_file/g' h5pfc
184 if test "x$do_link" = "xyes" -a -n "$output_file"; then
185 #Original code: compile_args="$compile_args -o $outputfile"
186 compile_args="$compile_args -o $output_file"
187 fi
I noticed when trying to use h5pfc that a file argument was being dropped before getting passed to the compiler. If I passed the (-c) switch before (-o) the argument would be passed but not the other way. Turns out that there was this typo and that fixed it.
With Typo:
Case (-o) before (-c) resulted in dropped argument and compiler fails:
h5pfc -show -o ESMF_Base.o -c ESMF_Base.f
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c -o ESMF_Base.f
Case (-c) before (-o) worked but WRF for example doesn't use this order:
h5pfc -show -c ESMF_Base.f -o ESMF_Base.o
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c ESMF_Base.f -o ESMF_Base.o
After fixing typo both parameters are passed to the compiler no matter what order is used.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Elena Pourmal The HDF Group http://hdfgroup.org
1800 So. Oak St., Suite 203, Champaign IL 61820
217.531.6112
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Line 185 of h5pfc on version 1.8.17 has a typo. outputfile should be output_file
sed -e 's/outputfile/output_file/g' h5pfc
184 if test "x$do_link" = "xyes" -a -n "$output_file"; then
185 #Original code: compile_args="$compile_args -o $outputfile"
186 compile_args="$compile_args -o $output_file"
187 fi
I noticed when trying to use h5pfc that a file argument was being dropped before getting passed to the compiler. If I passed the (-c) switch before (-o) the argument would be passed but not the other way. Turns out that there was this typo and that fixed it.
With Typo:
Case (-o) before (-c) resulted in dropped argument and compiler fails:
h5pfc -show -o ESMF_Base.o -c ESMF_Base.f
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c -o ESMF_Base.f
Case (-c) before (-o) worked but WRF for example doesn't use this order:
h5pfc -show -c ESMF_Base.f -o ESMF_Base.o
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c ESMF_Base.f -o ESMF_Base.o
After fixing typo both parameters are passed to the compiler no matter what order is used.
Elena
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Elena Pourmal The HDF Group http://hdfgroup.org
1800 So. Oak St., Suite 203, Champaign IL 61820
217.531.6112
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Line 185 of h5pfc on version 1.8.17 has a typo. outputfile should be output_file
sed -e 's/outputfile/output_file/g' h5pfc
184 if test "x$do_link" = "xyes" -a -n "$output_file"; then
185 #Original code: compile_args="$compile_args -o $outputfile"
186 compile_args="$compile_args -o $output_file"
187 fi
I noticed when trying to use h5pfc that a file argument was being dropped before getting passed to the compiler. If I passed the (-c) switch before (-o) the argument would be passed but not the other way. Turns out that there was this typo and that fixed it.
With Typo:
Case (-o) before (-c) resulted in dropped argument and compiler fails:
h5pfc -show -o ESMF_Base.o -c ESMF_Base.f
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c -o ESMF_Base.f
Case (-c) before (-o) worked but WRF for example doesn't use this order:
h5pfc -show -c ESMF_Base.f -o ESMF_Base.o
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c ESMF_Base.f -o ESMF_Base.o
After fixing typo both parameters are passed to the compiler no matter what order is used.
Yes, we have to fix it in both 1.8 and 1.10 and in all script.
Thank you!
Elena
···
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Elena Pourmal The HDF Group http://hdfgroup.org
1800 So. Oak St., Suite 203, Champaign IL 61820
217.531.6112
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
On Jun 7, 2016, at 8:44 AM, David Corredor <david@nsstc.uah.edu<mailto:david@nsstc.uah.edu>> wrote:
h5pcc and h5pc++ have the same problem by the way
thanks
David
On June 7, 2016 8:34:21 AM Elena Pourmal <epourmal@hdfgroup.org<mailto:epourmal@hdfgroup.org>> wrote:
Elena
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Elena Pourmal The HDF Group http://hdfgroup.org
1800 So. Oak St., Suite 203, Champaign IL 61820
217.531.6112
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
On Jun 6, 2016, at 5:29 PM, David Corredor <david@nsstc.uah.edu<mailto:david@nsstc.uah.edu><mailto:david@nsstc.uah.edu>> wrote:
Line 185 of h5pfc on version 1.8.17 has a typo. outputfile should be output_file
sed -e 's/outputfile/output_file/g' h5pfc
184 if test "x$do_link" = "xyes" -a -n "$output_file"; then
185 #Original code: compile_args="$compile_args -o $outputfile"
186 compile_args="$compile_args -o $output_file"
187 fi
I noticed when trying to use h5pfc that a file argument was being dropped before getting passed to the compiler. If I passed the (-c) switch before (-o) the argument would be passed but not the other way. Turns out that there was this typo and that fixed it.
With Typo:
Case (-o) before (-c) resulted in dropped argument and compiler fails:
h5pfc -show -o ESMF_Base.o -c ESMF_Base.f
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c -o ESMF_Base.f
Case (-c) before (-o) worked but WRF for example doesn't use this order:
h5pfc -show -c ESMF_Base.f -o ESMF_Base.o
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c ESMF_Base.f -o ESMF_Base.o
After fixing typo both parameters are passed to the compiler no matter what order is used.
