Not all Unix platforms have a libdl. FreeBSD, for example, has the
Incidentally, this should really be using
"target_link_libraries(${target} PRIVATE ${CMAKE_DL_LIBS})"
because it's not part of the exported link interface, and is only used
By the way, is there a public git/svn/other repo for tracking
Regards,
Patch follows:
diff -urN hdf5-1.10.1.orig/src/CMakeLists.txt hdf5-1.10.1/src/CMakeLists.txt
···
--
The University of Dundee is a registered Scottish Charity, No: SC015096
byrn
December 4, 2017, 6:52pm
2
Thank you for your contribution, we are always looking for ways to improve the CMake code.
Thank you for sharing!
···
On Monday, December 4, 2017 11:06:07 AM CST Roger Leigh wrote:
Not all Unix platforms have a libdl. FreeBSD, for example, has the
Incidentally, this should really be using
"target_link_libraries(${target} PRIVATE ${CMAKE_DL_LIBS})"
because it's not part of the exported link interface, and is only used
By the way, is there a public git/svn/other repo for tracking
Regards,
Patch follows:
diff -urN hdf5-1.10.1.orig/src/CMakeLists.txt hdf5-1.10.1/src/CMakeLists.txt
--
The University of Dundee is a registered Scottish Charity, No: SC015096
_______________________________________________Hdf-forum@lists.hdfgroup.org http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org https://twitter.com/hdf5
Unfortunately, my testing is showing that hdf5 is still broken due tohttps://ci.openmicroscopy.org/view/Files/job/OME-FILES-CPP-DEV-merge-win-superbuild/VSARCH=x64,VSCONFIG=Release,VSVERSION=14,label=maxquant-ome/823/consoleText ):
[1500/2985] Generating th5s.h5
I reported this to you, with a demonstration of how fix it, last year
This is on Windows, VS2015 x64, with the Ninja generator.
I can make a full patch for this, but it would need to be against the
Regards,
The University of Dundee is a registered Scottish Charity, No: SC015096
···
On 04/12/2017 18:52, Allen Byrne wrote:
Thank you for your contribution, we are always looking for ways to improve the CMake code.
byrn
December 4, 2017, 10:25pm
4
Copying changes have been incorporated into our development code. There has not been a new release of 1.10.
Allen
···
On Monday, December 4, 2017 3:01:06 PM CST Roger Leigh wrote:
On 04/12/2017 18:52, Allen Byrne wrote:
Unfortunately, my testing is showing that hdf5 is still broken due tohttps://ci.openmicroscopy.org/view/Files/job/OME-FILES-CPP-DEV-merge-win-superbuild/VSARCH=x64,VSCONFIG=Release,VSVERSION=14,label=maxquant-ome/823/consoleText ):
[1500/2985] Generating th5s.h5
I reported this to you, with a demonstration of how fix it, last year
This is on Windows, VS2015 x64, with the Ninja generator.
I can make a full patch for this, but it would need to be against the
Regards,
The University of Dundee is a registered Scottish Charity, No: SC015096
Thanks, this is working fine for me testing with the current development
I also opened this PR against CMakehttps://gitlab.kitware.com/cmake/cmake/merge_requests/1604 ) to fix the
Regards,
The University of Dundee is a registered Scottish Charity, No: SC015096
···
On 04/12/17 22:25, Allen Byrne wrote:
Copying changes have been incorporated into our development code. There has not been a new release of 1.10.
