MSYS2 MINGW-W64 HDF5 1.14.0 build scripts; send patches upstream?

kittisopikulm · January 13, 2023, 2:18am

I just modified the mingw-w64 build scripts in the MSYS2 project to build HDF5 1.14.0.

Are either of these patches worth upstream into the HDF5 library?

byrn · January 13, 2023, 5:48pm

Please add the szip definitly.
Why, the “-0” for the runtime name?

kittisopikulm · January 13, 2023, 5:58pm

See this comments concerning the SO version:

They seem to want to emulate the SO version on Linux and other *nix platforms rather than what this macro does at the moment:

github.com

HDFGroup/hdf5/blob/hdf5-1_14_0/config/cmake/HDFMacros.cmake#L169


  set (importprefix "${CMAKE_STATIC_LIBRARY_PREFIX}")
endif ()
if (${HDF_CFG_NAME} MATCHES "Debug" OR ${HDF_CFG_NAME} MATCHES "Developer")
  set (IMPORT_LIB_NAME ${LIB_DEBUG_NAME})
else ()
  set (IMPORT_LIB_NAME ${LIB_RELEASE_NAME})
endif ()


if (${libtype} MATCHES "SHARED")
  if (WIN32)
    if (MINGW)
      set_target_properties (${libtarget} PROPERTIES
          IMPORTED_IMPLIB "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${IMPORT_LIB_NAME}.lib"
          IMPORTED_LOCATION "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${IMPORT_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX}"
      )
    else ()
      set_target_properties (${libtarget} PROPERTIES
          IMPORTED_IMPLIB "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${HDF_BUILD_TYPE}/${CMAKE_IMPORT_LIBRARY_PREFIX}${IMPORT_LIB_NAME}${CMAKE_IMPORT_LIBRARY_SUFFIX}"
          IMPORTED_LOCATION "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${HDF_BUILD_TYPE}/${CMAKE_IMPORT_LIBRARY_PREFIX}${IMPORT_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX}"
      )
    endif ()

kittisopikulm · January 15, 2023, 10:29pm

Looks like h5py master branch also looks for a SO version number with non-MSVC builds:

github.com

h5py/h5py/blob/01be8231e9e143793ae09050610f794b590c8bac/setup_configure.py#L248-L253


if 'MSC' in sys.version:
    default_path = 'hdf5.dll'
    regexp = re.compile(r'^hdf5.dll')
else:
    default_path = 'libhdf5-0.dll'
    regexp = re.compile(r'^libhdf5-[0-9].dll')