HDFFV-9974 solved in 1.8 but not 1.10/develop branch

[elvis.stansvik]

Hi all,

I just tried my test case from

User-defined filter parameter parsing broken in h5repack?

Consider the attached noop_plugin.c. It contains a dynamically loaded filter plugin, with filter number 42, which does nothing except print out the received `cd_values` array in the filter function. Build the test plugin (on *NIX) with `make`. Then test the following: estan@newton:~/noop_plugin$ HDF5_PLUGIN_PATH=. h5repack -f UD=42,1,1 input.hdf5 output.hdf5 1 estan@newton:~/noop_plugin$ HDF5_PLUGIN_PATH=. h5repack -f UD=42,2,1,2 input.hdf5 output.hdf5 2 2 estan@newton:~/noop_plugin$ …

with 1.10.0 release and the develop branch and the problem is still present there.

Was the fix only applied to the 1.8 branch?

[byrn]

I have double-checked the code and the h5repack_parse.c file is identical in develop, 1.10 and 1.8 (except for a whitespace character in 1.8). This was completed in August 2016 for the 1.10.1 release.

Also, our dev process is to fix develop first, test and review the changes. Then apply the fix to 1.10 and test, before considering 1.8.

We will need to look for another reason why your test is failing.

Allen

[elvis.stansvik]

Alright, thanks for the info. I’ll double-check that the test case indeed fails with develop tomorrow.

Elvis

[elvis.stansvik]

Was unfortunately swamped at work so will have to be next week.