bug in 1.8.5

I just tried compiling 1.8.5 with debugging turned on to try and track down a problem I was having with segfaults in H5I_object_verify, and it wouldn't compile.

There's a semicolon missing (or several, depending on how you look at it)... in H5private.h:
#define H5_PUSH_FUNC(func_name) H5CS_push(#func_name);

I added the ; at the end of that to get it to compile. There are several uses of that macro, some have a semicolon at the end, others do not. I chose to tweak it there since that would allow me to fix it in one.

John,

Could you please specify configuration flags, OS, compiler and compiler flags you used?

Thank you!

Elena

···

On Jul 13, 2010, at 5:05 PM, John Knutson wrote:

I just tried compiling 1.8.5 with debugging turned on to try and track down a problem I was having with segfaults in H5I_object_verify, and it wouldn't compile.

There's a semicolon missing (or several, depending on how you look at it)... in H5private.h:
#define H5_PUSH_FUNC(func_name) H5CS_push(#func_name);

I added the ; at the end of that to get it to compile. There are several uses of that macro, some have a semicolon at the end, others do not. I chose to tweak it there since that would allow me to fix it in one.

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

CC=/opt/sunstudio12.1/bin/cc CFLAGS=-g ./configure --prefix=/opt/hdf5-1.8.5-debug --enable-cxx --with-szlib=/opt/local --enable-largefile --enable-debug=all --enable-codestack --enable-metadata-trace-file --enable-trace

SunOS --- 5.10 Generic_142900-07 sun4u sparc SUNW,Sun-Fire-V890 Solaris

Elena Pourmal wrote:

···

John,

Could you please specify configuration flags, OS, compiler and compiler flags you used?

Thank you!

Elena
On Jul 13, 2010, at 5:05 PM, John Knutson wrote:

I just tried compiling 1.8.5 with debugging turned on to try and track down a problem I was having with segfaults in H5I_object_verify, and it wouldn't compile.

There's a semicolon missing (or several, depending on how you look at it)... in H5private.h:
#define H5_PUSH_FUNC(func_name) H5CS_push(#func_name);

I added the ; at the end of that to get it to compile. There are several uses of that macro, some have a semicolon at the end, others do not. I chose to tweak it there since that would allow me to fix it in one.

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org
    
_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

John,

Thank you for the info. We will address the problem. Meanwhile, you do not need to use --enable-debug=all flag; just setting CFLAGS to -g will allow you to debug your code. If you narrow down the problem and it is in the library, please send us your example (help@hdfgroup.org)

Aside: we don't test --enable-debug=all on Solaris and here is the result :wink:
Not tested code is broken code, repeat 100 times :slight_smile:

Thanks again!

Elena

···

On Jul 14, 2010, at 9:25 AM, John Knutson wrote:

CC=/opt/sunstudio12.1/bin/cc CFLAGS=-g ./configure --prefix=/opt/hdf5-1.8.5-debug --enable-cxx --with-szlib=/opt/local --enable-largefile --enable-debug=all --enable-codestack --enable-metadata-trace-file --enable-trace

SunOS --- 5.10 Generic_142900-07 sun4u sparc SUNW,Sun-Fire-V890 Solaris

Elena Pourmal wrote:

John,

Could you please specify configuration flags, OS, compiler and compiler flags you used?

Thank you!

Elena
On Jul 13, 2010, at 5:05 PM, John Knutson wrote:

I just tried compiling 1.8.5 with debugging turned on to try and track down a problem I was having with segfaults in H5I_object_verify, and it wouldn't compile.

There's a semicolon missing (or several, depending on how you look at it)... in H5private.h:
#define H5_PUSH_FUNC(func_name) H5CS_push(#func_name);

I added the ; at the end of that to get it to compile. There are several uses of that macro, some have a semicolon at the end, others do not. I chose to tweak it there since that would allow me to fix it in one.

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org
   
_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

John,

We used Sun C 5.10 compiler and can reproduce the error; we also can confirm that --enable-debug=all has nothing to do with the error.

Thanks again for bringing this to our attention. We will add Sun 5.10 to our daily testing.

Elena

···

On Jul 14, 2010, at 9:53 AM, Elena Pourmal wrote:

John,

Thank you for the info. We will address the problem. Meanwhile, you do not need to use --enable-debug=all flag; just setting CFLAGS to -g will allow you to debug your code. If you narrow down the problem and it is in the library, please send us your example (help@hdfgroup.org)

Aside: we don't test --enable-debug=all on Solaris and here is the result :wink:
Not tested code is broken code, repeat 100 times :slight_smile:

Thanks again!

Elena
On Jul 14, 2010, at 9:25 AM, John Knutson wrote:

CC=/opt/sunstudio12.1/bin/cc CFLAGS=-g ./configure --prefix=/opt/hdf5-1.8.5-debug --enable-cxx --with-szlib=/opt/local --enable-largefile --enable-debug=all --enable-codestack --enable-metadata-trace-file --enable-trace

SunOS --- 5.10 Generic_142900-07 sun4u sparc SUNW,Sun-Fire-V890 Solaris

Elena Pourmal wrote:

John,

Could you please specify configuration flags, OS, compiler and compiler flags you used?

Thank you!

Elena
On Jul 13, 2010, at 5:05 PM, John Knutson wrote:

I just tried compiling 1.8.5 with debugging turned on to try and track down a problem I was having with segfaults in H5I_object_verify, and it wouldn't compile.

There's a semicolon missing (or several, depending on how you look at it)... in H5private.h:
#define H5_PUSH_FUNC(func_name) H5CS_push(#func_name);

I added the ; at the end of that to get it to compile. There are several uses of that macro, some have a semicolon at the end, others do not. I chose to tweak it there since that would allow me to fix it in one.

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org

_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@hdfgroup.org
http://mail.hdfgroup.org/mailman/listinfo/hdf-forum_hdfgroup.org